Fixing fingerprinting of table arguments #5086
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roborivers
suggested changes
Mar 27, 2025
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 6/603 tests failed ⚠.
The first 10 failing tests are:
timepart_readonly
yast_stat4scan_generated
yast
reco-ddlk-sql
logfill_logput_window_generated
logfill
Queries that select from the same table but with different arguments for hidden columns
(most notably `SELECT * FROM comdb2_transaction_logs('{file:offset}')`) are fingerprinted uniquely.
This patch fixes it.
Signed-off-by: Rivers Zhang <[email protected]>
riverszhang89
force-pushed
the
fingerprint_fix
branch
from
7f2b1d6 to
11ca80b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Queries that select from the same table but with different arguments for hidden columns (most notably
SELECT * FROM comdb2_transaction_logs('{file:offset}')) are fingerprinted uniquely. This patch fixes it.